[
https://issues.apache.org/jira/browse/SOLR-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079977#comment-16079977
]
ASF GitHub Bot commented on SOLR-10263:
---------------------------------------
GitHub user abhidemon opened a pull request:
https://github.com/apache/lucene-solr/pull/218
feat: Separate SuggestModes for WordBreak and WordJoin
We should be able to specify suggestModes for WordBreakSolrspellChecker,
and also separately for WordBreak and WordJoin. The feature will let `WordJoin`
and `WordBreak` override the suggestMode if they have been specified OR use
their parents, if not set.
See the latest update on https://issues.apache.org/jira/browse/SOLR-10263
for more details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/abhidemon/lucene-solr SOLR-10263.v2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/218.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #218
----
commit 51dd5c817687cb9117976d7e5b0ec257c9f90f74
Author: abhidemon <[email protected]>
Date: 2017-07-10T07:37:35Z
feat: Separate SuggestModes for WordBreak and WordJoin
We should be able to specify suggestModes for WordBreakSolrspellChecker,
and also separately for
WordBreak and WordJoin. The feature will let `WordJoin` and `WordBreak`
override the suggestMode if
they have been specified OR use their parents, if not set.
----
> Different SpellcheckComponents should have their own suggestMode
> ----------------------------------------------------------------
>
> Key: SOLR-10263
> URL: https://issues.apache.org/jira/browse/SOLR-10263
> Project: Solr
> Issue Type: Wish
> Security Level: Public(Default Security Level. Issues are Public)
> Components: spellchecker
> Reporter: Abhishek Kumar Singh
> Priority: Minor
>
> As of now, common spellcheck options are applied to all the
> SpellCheckComponents.
> This can create problem in the following case:-
> It may be the case that we want *DirectSolrSpellChecker* to ALWAYS_SUGGEST
> spellcheck suggestions.
> But we may want *WordBreakSpellChecker* to suggest only if the token is not
> in the index (SUGGEST_WHEN_NOT_IN_INDEX) .
> *Update:* Recently, we also figured out that, for
> {{WordBreakSolrSpellChecker}} also, both - The {{WordBreak}} and {{WordJoin}}
> should also have different suggestModes.
> We faced this problem in our case, wherein, Most of the WordJoin cases are
> those where the words individually are valid tokens, but what the users are
> looking for is actually a combination (wordjoin) of the two tokens.
> For example:-
> *gold mine sunglasses* : Here, both *gold* and *mine* are valid tokens. But
> the actual product being looked for is *goldmine sunglasses* , where
> *goldmine* is a brand.
> In such cases, we should recommend {{didYouMean:goldmine sunglasses}} . But
> this wont be possible because we had set {{SUGGEST_WHEN_NOT_IN_INDEX}} for
> {{WordBreakSolrSpellChecker}} (of which, WordJoin is a part) .
> For this, we should have separate suggestModes for both `wordJoin` as well as
> `wordBreak`.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
