[
https://issues.apache.org/jira/browse/SOLR-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044122#comment-13044122
]
Yonik Seeley commented on SOLR-2564:
------------------------------------
In QueryComponent, is it possible to remove this?
{code}
+ if (limitDefault < 0) {
+ limitDefault = searcher.maxDoc();
+ }
{code}
It wasn't necessary before, and there are advantages to preserving information
(like the fact that someone said "no limit" vs a specific number) until as late
as possible. That was previously handled by getMax() in Grouping.java, and I
still see it being called... so it should be OK?
> Integrating grouping module into Solr 4.0
> -----------------------------------------
>
> Key: SOLR-2564
> URL: https://issues.apache.org/jira/browse/SOLR-2564
> Project: Solr
> Issue Type: Improvement
> Reporter: Martijn van Groningen
> Assignee: Martijn van Groningen
> Fix For: 4.0
>
> Attachments: LUCENE-2564.patch, SOLR-2564.patch, SOLR-2564.patch
>
>
> Since work on grouping module is going well. I think it is time to wire this
> up in Solr.
> Besides the current grouping features Solr provides, Solr will then also
> support second pass caching and total count based on groups.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
