[
https://issues.apache.org/jira/browse/SOLR-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091013#comment-16091013
]
Shalin Shekhar Mangar commented on SOLR-11011:
----------------------------------------------
Thanks Dat.
# Can you move the {{incAndGetId}} method to Assign. That's the only place
which needs this method and ZkController is a kitchen-sink already so let's not
add another one there.
# Instead of adding new {{intToBytes}} and {{bytesToInt}} methods, why don't
you store the number as a string and use Integer.parseInt?
# The warning logged on BadVersionException should be a debug. We don't want to
scare people unnecessarily if there was a conflict.
# There's no need to catch InterruptedException, let it propagate up as it is.
# The changes in {{addReplicaTest}} of {{CollectionsAPIDistributedZkTest}} do
not seem to be related to this issue? Same for the changes in
CollectionsAPISolrJTest.
> Assign.buildCoreName can lead to error in creating a new core when
> legacyCloud=false
> ------------------------------------------------------------------------------------
>
> Key: SOLR-11011
> URL: https://issues.apache.org/jira/browse/SOLR-11011
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Cao Manh Dat
> Assignee: Cao Manh Dat
> Attachments: SOLR-11011.patch, SOLR-11011.patch
>
>
> Here are the case
> {code}
> shard1 : {
> node1 : shard1_replica1,
> node2 : shard1_replica2
> }
> {code}
> node2 go down, autoAddReplicasPlanAction is executed
> {code}
> shard1 : {
> node1 : shard1_replica1,
> node3 : shard1_replica3
> }
> {code}
> node2 back alive, because shard1_replica2 is removed from {{states.json}} so
> that core won't be loaded ( but it won't be removed neither ). Then node1 go
> down, Assign.buildCoreName will create a core with name=shard1_replica2 which
> lead to a failure.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
