[
https://issues.apache.org/jira/browse/SOLR-10916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096916#comment-16096916
]
Hoss Man commented on SOLR-10916:
---------------------------------
steve: i think those 3 tests are the only problematic ones -- if there were
others i would have almost certainly found them when I had to do this (either
that or they init a SolrCore with a schema that has no numeric fields)...
{noformat}
hossman@tray:~/lucene/dev [master] $ find -name \*.java | xargs grep SOLR-10916
./solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java: * TODO:
This method can be private once SOLR-10916 is resolved
./solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java: * TODO:
This method can be private once SOLR-10916 is resolved
./solr/core/src/test/org/apache/solr/cloud/TestAuthenticationFramework.java:
SolrTestCaseJ4.randomizeNumericTypesProperties(); // SOLR-10916
./solr/core/src/test/org/apache/solr/cloud/TestAuthenticationFramework.java:
SolrTestCaseJ4.clearNumericTypesProperties(); // SOLR-10916
./solr/core/src/test/org/apache/solr/cloud/TestSolrCloudWithKerberosAlt.java:
SolrTestCaseJ4.randomizeNumericTypesProperties(); // SOLR-10916
./solr/core/src/test/org/apache/solr/cloud/TestSolrCloudWithKerberosAlt.java:
SolrTestCaseJ4.clearNumericTypesProperties(); // SOLR-10916
./solr/core/src/test/org/apache/solr/cloud/TestMiniSolrCloudCluster.java:
public static void setupHackNumerics() { // SOLR-10916
./solr/core/src/test/org/apache/solr/cloud/TestMiniSolrCloudCluster.java:
public static void clearHackNumerics() { // SOLR-10916
{noformat}
> Any Solr test using MiniSolrCloud or Solr Core's should extend
> SolrTestCaseJ4/SolrCloudTestCase
> -----------------------------------------------------------------------------------------------
>
> Key: SOLR-10916
> URL: https://issues.apache.org/jira/browse/SOLR-10916
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Assignee: Steve Rowe
> Attachments: SOLR-10916.patch, SOLR-10916.patch
>
>
> We have a non-trivial number of tests that extend LuceneTestCase directly.
> For "utility" method minded tests, this is fine - but for any test that wants
> to instantiate re-use shared config files to instantiate SolrCores, or
> instances of MiniSolrCloudCluster, this makes these tests really cumbersome
> to maintain and deal with because htye don't leverage the existing
> randomization setup logic in SolrTestCaseJ4.
> we should fix these tests where applicable
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
