[ 
https://issues.apache.org/jira/browse/SOLR-11093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16098636#comment-16098636
 ] 

David Smiley commented on SOLR-11093:
-------------------------------------

Requiring DocValues for numerics on a GraphQuery is fine with me.  Is there a 
back-compat concern?

Maybe LongSet could use more javadocs if it's going to be shared.  The 
constructor should actually assert (or throw) that the argument is a power of 
2.  And it appears that the LongIterator returned *must* be used in a standard 
fashion in which hasNext is *always* called before next(); yes?  Since the set 
size is known, maybe it could be adjusted to use a countDown integer approach, 
yet still be very fast/simple?

> implement Points/Numeric support for graph query
> ------------------------------------------------
>
>                 Key: SOLR-11093
>                 URL: https://issues.apache.org/jira/browse/SOLR-11093
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Yonik Seeley
>            Assignee: Yonik Seeley
>             Fix For: 7.0
>
>         Attachments: SOLR-11093.patch, SOLR-11093.patch
>
>
> It looks like GraphQueryTest only has tests for strings.  We should add tests 
> for numeric fields and then enable points randomization.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to