[
https://issues.apache.org/jira/browse/SOLR-11151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Rowe updated SOLR-11151:
------------------------------
Attachment: SOLR-11151.patch
Patch with added test that reproduces 100% of the time without a fix, and a fix
(basically: don't assume that the previous bean value is non-null).
I'll beast this for a while and then commit if I see no failures.
> SolrInfoMBeanHandler.getDiff() ADD case non-functional: NPE when a bean value
> goes from null -> non-null
> --------------------------------------------------------------------------------------------------------
>
> Key: SOLR-11151
> URL: https://issues.apache.org/jira/browse/SOLR-11151
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Steve Rowe
> Assignee: Steve Rowe
> Fix For: 7.0, master (8.0), 7.1
>
> Attachments: SOLR-11151.patch
>
>
> {{MBeansHandler.testDiff()}} has been failing regularly on Jenkins, e.g.
> [https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/20192/]:
> {noformat}
> [junit4] 2> NOTE: reproduce with: ant test -Dtestcase=MBeansHandlerTest
> -Dtests.method=testDiff -Dtests.seed=CD7B1EB232DD9490 -Dtests.multiplier=3
> -Dtests.slow=true -Dtests.locale=es-PA -Dtests.timezone=Asia/Phnom_Penh
> -Dtests.asserts=true -Dtests.file.encoding=ISO-8859-1
> [junit4] ERROR 0.02s J0 | MBeansHandlerTest.testDiff <<<
> [junit4] > Throwable #1: java.lang.NullPointerException
> [junit4] > at
> __randomizedtesting.SeedInfo.seed([CD7B1EB232DD9490:86DDA29226BACF0]:0)
> [junit4] > at
> org.apache.solr.handler.admin.SolrInfoMBeanHandler.diffObject(SolrInfoMBeanHandler.java:240)
> [junit4] > at
> org.apache.solr.handler.admin.SolrInfoMBeanHandler.diffNamedList(SolrInfoMBeanHandler.java:219)
> [junit4] > at
> org.apache.solr.handler.admin.SolrInfoMBeanHandler.getDiff(SolrInfoMBeanHandler.java:187)
> [junit4] > at
> org.apache.solr.handler.admin.SolrInfoMBeanHandler.handleRequestBody(SolrInfoMBeanHandler.java:87)
> [junit4] > at
> org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:177)
> [junit4] > at
> org.apache.solr.core.SolrCore.execute(SolrCore.java:2473)
> [junit4] > at
> org.apache.solr.util.TestHarness.query(TestHarness.java:337)
> [junit4] > at
> org.apache.solr.util.TestHarness.query(TestHarness.java:319)
> [junit4] > at
> org.apache.solr.handler.admin.MBeansHandlerTest.testDiff(MBeansHandlerTest.java:57)
> [junit4] > at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [junit4] > at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> [junit4] > at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> [junit4] > at
> java.base/java.lang.reflect.Method.invoke(Method.java:564)
> [junit4] > at java.base/java.lang.Thread.run(Thread.java:844)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
