[ 
https://issues.apache.org/jira/browse/SOLR-11158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103770#comment-16103770
 ] 

Jason Gerlowski commented on SOLR-11158:
----------------------------------------

Might be speaking in ignorance here, but I could imagine people being bitten by 
a change like this.  It'd be pretty easy for a client with a bug in their 
request building code to accidentally delete their preferences/policies because 
a variable on their end was unexpectedly null.

Would it be reasonable to rely on a different flag value here instead?  Maybe 
"{}" or "[]" (empty JSON, empty JSON array) instead?

Feel free to discard this suggestion though, as I don't have a ton of context 
on this part of the code.



> set-cluster-preferences & set-cluster-policy must accept null value to delete 
> the entries
> -----------------------------------------------------------------------------------------
>
>                 Key: SOLR-11158
>                 URL: https://issues.apache.org/jira/browse/SOLR-11158
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Noble Paul
>
> {code}
> {set-cluster-preferences:null }
> {code}
> should remove the entry altgether instead of throwing an error
>  
> and 
> {code}
> {set-cluster-policy : null }
> {code}
>  should also behave similarly



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to