[
https://issues.apache.org/jira/browse/SOLR-11153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104275#comment-16104275
]
Jason Gerlowski commented on SOLR-11153:
----------------------------------------
LGTM.
As for having a place to record default values, I think it'd definitely be an
improvement, but I'm not sure of a place that exists now. The
"org.apache.solr.common.params" package in SolrJ comes the closest AFAICT, but
I'm not sure that's a good fit here. Another option would be to put the
default values in {{IndexSchema}}- it looks like there are constants there for
many of the param names. Might be reasonable to put default values there too.
> Incomplete schema results in mysterious error
> ---------------------------------------------
>
> Key: SOLR-11153
> URL: https://issues.apache.org/jira/browse/SOLR-11153
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: 4.4, 5.0, 6.0
> Reporter: Shawn Heisey
> Assignee: Shawn Heisey
> Attachments: SOLR-11153.patch
>
>
> A user on the mailing list was getting a very arcane error trying to load a
> very minimal solrconfig and schema. The error was ultimately caused by NPE
> in SchemaXmlWriter.java at line 85.
> The actual problem turned out to be a missing "name" attribute from the top
> level XML "schema" element in the file.
> {code}
> <?xml version="1.0" encoding="UTF-8" ?>
> <schema version="1.5">
> <fields>
> <field name="_id" type="string" indexed="true" stored="true"
> required="true"/>
> <field name="title" type="string" indexed="true" stored="true"
> required="true"/>
> </fields>
> <uniqueKey>_id</uniqueKey>
> <types>
> <fieldType name="string" class="solr.StrField" />
> </types>
> </schema>
> {code}
> As written, the code will explode with an NPE if either the name or version
> is missing from the schema. Although I can state that the user's minimal
> config/schema are not very useful, Solr should not blow up without a useful
> error message, and in this case, I think it should have worked, only emitting
> a WARN message and assuming a default name.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
