[ https://issues.apache.org/jira/browse/LUCENE-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044860#comment-13044860 ]
David Smiley commented on LUCENE-2645: -------------------------------------- Thanks for the test Korusaka. I didn't realize my bug report last year that an assert condition's ">" should become ">=" was insufficient for a committer to simply make the 1-char change. I guess I should work on creating tests for nearly everything for my bug reports to get more traction. :-| > False assertion of >0 position delta in StandardPostingsWriterImpl > ------------------------------------------------------------------ > > Key: LUCENE-2645 > URL: https://issues.apache.org/jira/browse/LUCENE-2645 > Project: Lucene - Java > Issue Type: Bug > Components: core/index > Affects Versions: 4.0 > Reporter: David Smiley > Assignee: Michael McCandless > Priority: Minor > Fix For: 4.0 > > Attachments: LuceneTrunkAssertErrorReproducer.java > > > StandardPostingsWriterImpl line 159 is: > {code:java} > assert delta > 0 || position == 0 || position == -1: "position=" + > position + " lastPosition=" + lastPosition; // not quite right (if > pos=0 is repeated twice we don't catch it) > {code} > I enable assertions when I run my unit tests and I've found this assertion to > fail when delta is 0 which occurs when the same position value is sent in > twice in arrow. Once I added RemoveDuplicatesTokenFilter, this problem went > away. Should I really be forced to add this filter? I think delta >= 0 > would be a better assertion. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org