[ https://issues.apache.org/jira/browse/SOLR-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044940#comment-13044940 ]
Martijn van Groningen commented on SOLR-2564: --------------------------------------------- bq. But: why not just use Double.MAX_VALUE? Yes, I should have used that and I'll change that. I thought that the size was initially used to create the underline array. But it isn't! The array inside the caching collector initially starts with a length 128 and grows when needed. How I've currently implemented LUCENE-3097 is that it will only get the most relevant document of each group. In terms of SOLR-236 that is the same as using collapse.threshold=1. I think what Yonik means is increasing the threshold so more documents and up in the docset, that eventually is used by the facet component. Increasing this threshold also means setting when to start to collapse. So when setting the collapse.threshold=3 this means that from the 4th document the collapsing starts. I think that the whole collaps.threshold feature doesn't scale very well. Anyway, I think when we go wire the 2nd method (LUCENE-3097) into Solr, we should first make it work for the most relevant group documents. > Integrating grouping module into Solr 4.0 > ----------------------------------------- > > Key: SOLR-2564 > URL: https://issues.apache.org/jira/browse/SOLR-2564 > Project: Solr > Issue Type: Improvement > Reporter: Martijn van Groningen > Assignee: Martijn van Groningen > Fix For: 4.0 > > Attachments: LUCENE-2564.patch, SOLR-2564.patch, SOLR-2564.patch, > SOLR-2564.patch, SOLR-2564.patch > > > Since work on grouping module is going well. I think it is time to wire this > up in Solr. > Besides the current grouping features Solr provides, Solr will then also > support second pass caching and total count based on groups. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org