[
https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110811#comment-16110811
]
Karl Wright edited comment on LUCENE-7906 at 8/2/17 12:56 PM:
--------------------------------------------------------------
[~ivera], thanks for the tests! I've had a look, and I think this is in good
enough shape to commit.
The only comments I have are:
(1) If there's any thought that the "intersects" method being added to
GeoPolygon might need to be added to other shapes, e.g. GeoCircle or GeoPath,
then we should think about the interface structure more, as you have hinted.
There are a number of possibilities here; I'm interested mainly in permitting
shapes that do not understand how to intersect with other shapes. Maybe we
want to insert another level in the interface hierarchy that would allow this
characteristic to be separable, e.g. GeoIntersectableShape?
(2) The randomized tests seem to concentrate on PlanetModel.SPHERE. Are there
any WGS84 tests? That's where a lot of issues might arise.
was (Author: [email protected]):
[~ivera], thanks for the tests! I will have a look at this shortly.
Does the new patch change the interface hierarchy in this way? If so, I will
want to propose something else to preserve the ability for shapes to *not*
support intersection.
> Spatial relationship between Geoshapes
> --------------------------------------
>
> Key: LUCENE-7906
> URL: https://issues.apache.org/jira/browse/LUCENE-7906
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial3d
> Reporter: Ignacio Vera
> Assignee: Karl Wright
> Attachments: LUCENE-7906.patch
>
>
> Hi,
> Working with geosahpes and trying to resolve spatial relationships between
> them I came accross a big limitation when trying to solve the relationship
> between two geopolygons. This object does not expose the internal structure.
> In particular at some point, it is necessary to check if one polygon
> intersects the edges of the other polygon which currently is not possible as
> edges are not exposed.
> To be able to perform such operation it can be several options. The ones I
> can think of are:
> 1) Expose the edges of the polygon ( and probably the notable points for the
> edges) adding getters in the GeoPolygon interface. Easy to implement and
> leave users the responsability of coding the spatial relationship.
> 2) Extends GeoPolygon interface to extends geoarea and leave the object make
> the spatial relationship.
> 3) Extends GeoShape interface so all shapes can infer the spatial
> relationship with other GeoShapes.
> I might be bias as my interest is in 2d Shapes in the unit sphere and there
> might be some cases which what I propose cannot be implemented or are againts
> the aim of the library.
> What do you think?
> Cheers,
> Ignacio
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
