Hi,
yes you’re right: Jenkins and also my computer uses Unix linefeeds. So I think Steve’s script has a bug with newlines, although I think the regex is correct, but maybe it’s a side-effect of another regex (I don’t fully understand what the check should do!). Uwe ----- Uwe Schindler Achterdiek 19, D-28357 Bremen http://www.thetaphi.de <http://www.thetaphi.de/> eMail: u...@thetaphi.de From: Karl Wright [mailto:daddy...@gmail.com] Sent: Friday, August 4, 2017 12:20 AM To: Lucene/Solr dev <dev@lucene.apache.org> Subject: Re: ant precommit failing due to the solr dev guide _144 also doesn't work for me. Looking at one of the .adoc files, the checkout has CR/LF at the end of the line, right after the "->" eg: <!-- Updated from http://www.exchangerate.com/ at 2011-09-27 --> Is your git configured to checkout in native format? Karl On Thu, Aug 3, 2017 at 5:42 PM, Karl Wright <daddy...@gmail.com <mailto:daddy...@gmail.com> > wrote: 1.8.0_45 didn't work either; downloading _144 now (will take a while). Karl On Thu, Aug 3, 2017 at 5:09 PM, Karl Wright <daddy...@gmail.com <mailto:daddy...@gmail.com> > wrote: Thanks, I'll update. Karl On Thu, Aug 3, 2017 at 12:30 PM, Uwe Schindler <u...@thetaphi.de <mailto:u...@thetaphi.de> > wrote: Oh, I think I know: Java 8 update 5: Please update and try again. Such old versions had problems in String#split(), I don’t exactly remember but they were able to return some duplicate/empty tokens. Uwe ----- Uwe Schindler Achterdiek 19, D-28357 Bremen http://www.thetaphi.de <http://www.thetaphi.de/> eMail: u...@thetaphi.de <mailto:u...@thetaphi.de> From: Uwe Schindler [mailto:u...@thetaphi.de <mailto:u...@thetaphi.de> ] Sent: Thursday, August 3, 2017 6:28 PM To: 'dev@lucene.apache.org <mailto:dev@lucene.apache.org> ' <dev@lucene.apache.org <mailto:dev@lucene.apache.org> > Subject: RE: ant precommit failing due to the solr dev guide I see no problems on windows jenkins and no problems on my local computer. Steve’s script has a regex for matching newlines, but this one looks correct. Would it be possible to check, how the newlines look like on your *.adoc files (e.g., post a hexdump)? Uwe ----- Uwe Schindler Achterdiek 19, D-28357 Bremen http://www.thetaphi.de <http://www.thetaphi.de/> eMail: u...@thetaphi.de <mailto:u...@thetaphi.de> From: Uwe Schindler [mailto:u...@thetaphi.de] Sent: Thursday, August 3, 2017 5:33 PM To: dev@lucene.apache.org <mailto:dev@lucene.apache.org> Subject: RE: ant precommit failing due to the solr dev guide Hi, Could be an newline issue in the groovy script… On windows some regex using \n or similar won’t match…. I will check on my system. ----- Uwe Schindler Achterdiek 19, D-28357 Bremen http://www.thetaphi.de <http://www.thetaphi.de/> eMail: u...@thetaphi.de <mailto:u...@thetaphi.de> From: Karl Wright [mailto:daddy...@gmail.com] Sent: Thursday, August 3, 2017 5:08 PM To: Lucene/Solr dev <dev@lucene.apache.org <mailto:dev@lucene.apache.org> > Subject: Re: ant precommit failing due to the solr dev guide Sure -- this is Windows 10, an older JDK 8: C:\Program Files\Java\jdk1.8.0_05 Anything else you are interested in? Karl On Thu, Aug 3, 2017 at 11:04 AM, Steve Rowe <sar...@gmail.com <mailto:sar...@gmail.com> > wrote: Hi Karl, I looked at a couple of the errors, and they were all in "[source]" sections, which should be exempted from the “unescaped symbol” check, which is performed in the "-validate-source-patterns” target in the top-level build.xml. The groovy method “checkForUnescapedSymbolSubstitutions” is where this “[source]” section exemption is supposed to happen. The “-validate-source-patterns” target depends on “resolve-groovy”, which pins the version, so I don’t think this is an issue of stale build tools. I don’t know how to reproduce the problem you’re seeing, so I’m not sure how to fix it. Could you provide details on your platform? -- Steve www.lucidworks.com <http://www.lucidworks.com> > On Aug 3, 2017, at 10:20 AM, Karl Wright <daddy...@gmail.com > <mailto:daddy...@gmail.com> > wrote: > > 'When I run `ant precommit` on master on my machine, I don't get those > errors. Is your branch out of date perhaps?' > > This is on master, and yes, my work area is up to date. > Any other ideas? Have the required versions of some of the build tools > changed recently or something? > > Karl > > > > On Thu, Aug 3, 2017 at 9:18 AM, Cassandra Targett <casstarg...@gmail.com > <mailto:casstarg...@gmail.com> > wrote: > Those are documentation-lint validations added via SOLR-10883 for the > Solr Ref Guide (committed weeks ago). > > When I run `ant precommit` on master on my machine, I don't get those > errors. Is your branch out of date perhaps? > > On Thu, Aug 3, 2017 at 7:56 AM, Karl Wright <daddy...@gmail.com > <mailto:daddy...@gmail.com> > wrote: > > > > Getting this output: > > > > ... > > [source-patterns] Unescaped symbol "->" on line #84: > > solr/solr-ref-guide/src/res > > ponse-writers.adoc > > [source-patterns] Unescaped symbol "->" on line #185: > > solr/solr-ref-guide/src/re > > sponse-writers.adoc > > [source-patterns] Unescaped symbol "->" on line #87: > > solr/solr-ref-guide/src/res > > ult-clustering.adoc > > [source-patterns] Unescaped symbol "->" on line #114: > > solr/solr-ref-guide/src/re > > sult-clustering.adoc > > [source-patterns] Unescaped symbol "->" on line #127: > > solr/solr-ref-guide/src/re > > sult-clustering.adoc > > [source-patterns] Unescaped symbol "->" on line #162: > > solr/solr-ref-guide/src/re > > sult-clustering.adoc > > [source-patterns] Unescaped symbol "->" on line #168: > > solr/solr-ref-guide/src/re > > sult-clustering.adoc > > [source-patterns] Unescaped symbol "->" on line #185: > > solr/solr-ref-guide/src/re > > sult-clustering.adoc > > [source-patterns] Unescaped symbol "->" on line #191: > > solr/solr-ref-guide/src/re > > sult-clustering.adoc > > [source-patterns] Unescaped symbol "->" on line #196: > > solr/solr-ref-guide/src/re > > sult-clustering.adoc > > [source-patterns] Unescaped symbol "->" on line #42: > > solr/solr-ref-guide/src/sch > > ema-factory-definition-in-solrconfig.adoc > > [source-patterns] Unescaped symbol "->" on line #73: > > solr/solr-ref-guide/src/sch > > ema-factory-definition-in-solrconfig.adoc > > [source-patterns] Unescaped symbol "->" on line #131: > > solr/solr-ref-guide/src/sc > > hemaless-mode.adoc > > [source-patterns] Unescaped symbol "->" on line #153: > > solr/solr-ref-guide/src/sc > > hemaless-mode.adoc > > [source-patterns] Unescaped symbol "<-" on line #43: > > solr/solr-ref-guide/src/sol > > r-jdbc-r.adoc > > [source-patterns] Unescaped symbol "<-" on line #45: > > solr/solr-ref-guide/src/sol > > r-jdbc-r.adoc > > [source-patterns] Unescaped symbol "<-" on line #48: > > solr/solr-ref-guide/src/sol > > r-jdbc-r.adoc > > [source-patterns] Unescaped symbol "->" on line #46: > > solr/solr-ref-guide/src/spe > > ll-checking.adoc > > [source-patterns] Unescaped symbol "->" on line #106: > > solr/solr-ref-guide/src/sp > > ell-checking.adoc > > [source-patterns] Unescaped symbol "<=" on line #443: > > solr/solr-ref-guide/src/st > > ream-evaluators.adoc > > [source-patterns] Unescaped symbol "<=" on line #444: > > solr/solr-ref-guide/src/st > > ream-evaluators.adoc > > [source-patterns] Unescaped symbol "<=" on line #445: > > solr/solr-ref-guide/src/st > > ream-evaluators.adoc > > [source-patterns] Unescaped symbol "<=" on line #446: > > solr/solr-ref-guide/src/st > > ream-evaluators.adoc > > [source-patterns] Unescaped symbol "->" on line #38: > > solr/solr-ref-guide/src/tak > > ing-solr-to-production.adoc > > [source-patterns] Unescaped symbol "->" on line #41: > > solr/solr-ref-guide/src/the > > -query-elevation-component.adoc > > [source-patterns] Unescaped symbol "->" on line #88: > > solr/solr-ref-guide/src/the > > -query-elevation-component.adoc > > [source-patterns] Unescaped symbol "->" on line #89: > > solr/solr-ref-guide/src/the > > -query-elevation-component.adoc > > [source-patterns] Unescaped symbol "->" on line #294: > > solr/solr-ref-guide/src/to > > kenizers.adoc > > [source-patterns] Unescaped symbol "->" on line #361: > > solr/solr-ref-guide/src/tr > > ansforming-and-indexing-custom-json.adoc > > [source-patterns] Unescaped symbol "->" on line #365: > > solr/solr-ref-guide/src/tr > > ansforming-and-indexing-custom-json.adoc > > [source-patterns] Unescaped symbol "->" on line #367: > > solr/solr-ref-guide/src/tr > > ansforming-and-indexing-custom-json.adoc > > [source-patterns] Unescaped symbol "->" on line #60: > > solr/solr-ref-guide/src/uim > > a-integration.adoc > > [source-patterns] Unescaped symbol "->" on line #65: > > solr/solr-ref-guide/src/uim > > a-integration.adoc > > [source-patterns] Unescaped symbol "->" on line #199: > > solr/solr-ref-guide/src/up > > loading-data-with-index-handlers.adoc > > [source-patterns] Unescaped symbol "->" on line #209: > > solr/solr-ref-guide/src/up > > loading-data-with-index-handlers.adoc > > [source-patterns] Unescaped symbol "->" on line #184: > > solr/solr-ref-guide/src/up > > loading-data-with-solr-cell-using-apache-tika.adoc > > [source-patterns] Unescaped symbol "->" on line #187: > > solr/solr-ref-guide/src/up > > loading-data-with-solr-cell-using-apache-tika.adoc > > [source-patterns] Unescaped symbol "->" on line #192: > > solr/solr-ref-guide/src/up > > loading-data-with-solr-cell-using-apache-tika.adoc > > [source-patterns] Unescaped symbol "->" on line #251: > > solr/solr-ref-guide/src/up > > loading-structured-data-store-data-with-the-data-import-handler.adoc > > [source-patterns] Unescaped symbol "->" on line #256: > > solr/solr-ref-guide/src/up > > loading-structured-data-store-data-with-the-data-import-handler.adoc > > [source-patterns] Unescaped symbol "->" on line #260: > > solr/solr-ref-guide/src/up > > loading-structured-data-store-data-with-the-data-import-handler.adoc > > [source-patterns] Unescaped symbol "->" on line #481: > > solr/solr-ref-guide/src/up > > loading-structured-data-store-data-with-the-data-import-handler.adoc > > [source-patterns] Unescaped symbol "->" on line #484: > > solr/solr-ref-guide/src/up > > loading-structured-data-store-data-with-the-data-import-handler.adoc > > [source-patterns] Unescaped symbol "->" on line #494: > > solr/solr-ref-guide/src/up > > loading-structured-data-store-data-with-the-data-import-handler.adoc > > [source-patterns] Unescaped symbol "->" on line #497: > > solr/solr-ref-guide/src/up > > loading-structured-data-store-data-with-the-data-import-handler.adoc > > [source-patterns] Unescaped symbol "->" on line #641: > > solr/solr-ref-guide/src/up > > loading-structured-data-store-data-with-the-data-import-handler.adoc > > [source-patterns] Unescaped symbol "->" on line #694: > > solr/solr-ref-guide/src/up > > loading-structured-data-store-data-with-the-data-import-handler.adoc > > [source-patterns] Unescaped symbol "->" on line #703: > > solr/solr-ref-guide/src/up > > loading-structured-data-store-data-with-the-data-import-handler.adoc > > [source-patterns] Unescaped symbol "->" on line #758: > > solr/solr-ref-guide/src/up > > loading-structured-data-store-data-with-the-data-import-handler.adoc > > [source-patterns] Unescaped symbol "->" on line #932: > > solr/solr-ref-guide/src/up > > loading-structured-data-store-data-with-the-data-import-handler.adoc > > [source-patterns] Unescaped symbol "->" on line #969: > > solr/solr-ref-guide/src/up > > loading-structured-data-store-data-with-the-data-import-handler.adoc > > [source-patterns] Unescaped symbol "->" on line #996: > > solr/solr-ref-guide/src/up > > loading-structured-data-store-data-with-the-data-import-handler.adoc > > [source-patterns] Unescaped symbol "->" on line #1012: > > solr/solr-ref-guide/src/u > > ploading-structured-data-store-data-with-the-data-import-handler.adoc > > [source-patterns] Unescaped symbol "->" on line #1029: > > solr/solr-ref-guide/src/u > > ploading-structured-data-store-data-with-the-data-import-handler.adoc > > [source-patterns] Unescaped symbol "=>" on line #36: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #37: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #38: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #39: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #40: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #41: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #42: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #43: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #45: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #46: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #47: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #48: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #49: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #51: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #52: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #53: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #54: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #55: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #56: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #57: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #58: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #59: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #61: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #62: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #63: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #64: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #65: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #67: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #68: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #69: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #70: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #71: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #72: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #73: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #74: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #75: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #77: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #78: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #79: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #80: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #81: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #83: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #89: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #90: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #91: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #92: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #93: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #94: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #95: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #96: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "=>" on line #97: > > solr/solr-ref-guide/src/usi > > ng-solr-from-ruby.adoc > > [source-patterns] Unescaped symbol "->" on line #37: > > solr/solr-ref-guide/src/vel > > ocity-response-writer.adoc > > [source-patterns] Unescaped symbol "->" on line #95: > > solr/solr-ref-guide/src/wor > > king-with-currencies-and-exchange-rates.adoc > > [source-patterns] Unescaped symbol "->" on line #101: > > solr/solr-ref-guide/src/wo > > rking-with-currencies-and-exchange-rates.adoc > > [source-patterns] Unescaped symbol "->" on line #106: > > solr/solr-ref-guide/src/wo > > rking-with-currencies-and-exchange-rates.adoc > > > > BUILD FAILED > > > > Who knows about this and can address it? > > Karl > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > <mailto:dev-unsubscr...@lucene.apache.org> > For additional commands, e-mail: dev-h...@lucene.apache.org > <mailto:dev-h...@lucene.apache.org> > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org <mailto:dev-unsubscr...@lucene.apache.org> For additional commands, e-mail: dev-h...@lucene.apache.org <mailto:dev-h...@lucene.apache.org>