[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116233#comment-16116233
]
Karl Wright commented on LUCENE-7918:
-------------------------------------
Hi [~ivera], I think this looks pretty good actually. The new API exposure is
minimal, but all public classes in geom should be annotated with
"lucene-experimental" to be sure we can change them if we need to.
Also, you have a number of unnecessary casts in GeoPolygonTest:
{code}
- GeoPolygon polygon =
(GeoPolygon)((GeoCompositePolygon)GeoPolygonFactory.makeGeoPolygon(PlanetModel.SPHERE,
points)).shapes.get(0);
+ GeoPolygon polygon =
((GeoCompositePolygon)GeoPolygonFactory.makeGeoPolygon(PlanetModel.SPHERE,
points)).shapes.get(0);
GeoPolygon polygonConcave =
GeoPolygonFactory.makeGeoConcavePolygon(PlanetModel.SPHERE,points);
assertEquals(polygon,polygonConcave);
{code}
There's no need to cast to a GeoPolygon; the output of makeGeoPolygon is
already a GeoPolygon.
I think you're almost there; one more pass and we're good.
> Give access to members of a composite shape
> -------------------------------------------
>
> Key: LUCENE-7918
> URL: https://issues.apache.org/jira/browse/LUCENE-7918
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial3d
> Reporter: Ignacio Vera
> Assignee: Karl Wright
> Attachments: LUCENE-7918.patch
>
>
> Hi [~daddywri],
> I hope this is my last point in my wish list. In order to serialize objects I
> need to access the members of a composite geoshape. This is currently not
> possible so I was wondering if it is possible to add to more methods to the
> class GeoCompositeMembershipShape:
> public int size()
> public GeoMembershipShape getShape(int index)
> Thanks,
> Ignacio
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
