[ 
https://issues.apache.org/jira/browse/SOLR-11195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122154#comment-16122154
 ] 

Andrzej Bialecki  commented on SOLR-11195:
------------------------------------------

Makes sense, +1.

(Originally I thought that specifying groups as "shard" or "cluster" would 
allow users to simplify their configs, but it probably leads to more confusion 
and inconsistency, and indeed the logic prevented users from subclassing.)

> require class attribute for SolrShardReporter and SolrClusterReporter 
> configurations
> ------------------------------------------------------------------------------------
>
>                 Key: SOLR-11195
>                 URL: https://issues.apache.org/jira/browse/SOLR-11195
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-11195.patch
>
>
> This brings the two classes in line with the 
> https://lucene.apache.org/solr/guide/6_6/metrics-reporting.html 
> documentation. In doing so it also tidies up the (private) 
> _SolrMetricManager.preparePlugin_ logic which currently would reject class 
> attribute values other than the base _SolrShardReporter_ and 
> _SolrClusterReporter_ classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to