[ 
https://issues.apache.org/jira/browse/SOLR-11221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125547#comment-16125547
 ] 

ASF subversion and git services commented on SOLR-11221:
--------------------------------------------------------

Commit ff8b90b9acb7685a77d3b4af14f18aedb681176f in lucene-solr's branch 
refs/heads/master from [~ab]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ff8b90b ]

SOLR-11221: Fix precommit issues.


> SolrJmxReporter broken on core reload
> -------------------------------------
>
>                 Key: SOLR-11221
>                 URL: https://issues.apache.org/jira/browse/SOLR-11221
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>    Affects Versions: 6.6, 7.0, 6.7, master (8.0)
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>            Priority: Critical
>         Attachments: SOLR-11221.patch
>
>
> {{SolrJmxReporter}} uses Dropwizard's {{JmxReporter}}, which in turn uses a 
> {{MetricRegistry}} listener to report newly added metrics as MBeans, and to 
> unregister them from MBeanServer when the reporter is closed, which happens 
> when core is closed.
> The metrics API keeps around existing metrics in {{solr.core.*}} registries 
> to help maintain continuous metrics in presence of core reloads. However, 
> this means that some of these metric instances are not registered anew when a 
> core is reloaded - and for these metrics the listener won't fire, so the 
> MBeans won't be registered.
> This limitation is a result of the use of {{MetricRegistryListener}} in 
> {{JmxReporter}} and can't be fixed without reimplementing this class. Another 
> possible approach would be to configure the {{JmxReporter}} to use a 
> "mirroring" registry instead, which will be populated with existing metrics 
> from the original registry (thus generating "metric added" events) and then 
> kept in sync with the main registry via a listener.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to