[
https://issues.apache.org/jira/browse/SOLR-11164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128629#comment-16128629
]
Christine Poerschke commented on SOLR-11164:
--------------------------------------------
bq. Is it better to create the patch from the master branch?
Good question. Yes, I think so, typically patches are against master branch
(unless the issue is broken only in (say) branch_7x) and once committed to
master branch it would be cherry-pick backported to other branches.
https://wiki.apache.org/solr/HowToContribute has (much) more detailed info e.g.
including _ant precommit_ etc.
> OriginalScoreFeature causes NullPointerException during feature logging with
> SolrCloud mode.
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-11164
> URL: https://issues.apache.org/jira/browse/SOLR-11164
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
> Affects Versions: 6.6
> Reporter: Yuki Yano
> Attachments: SOLR-11164.patch, SOLR-11164.patch
>
>
> In FeatureTransfer, OriginalScoreFeature uses original Query instance
> preserved in LTRScoringQuery for the evaluation.
> This query is set in RankQuery#wrap during QueryComponent#process.
> With SolrCloud mode, document searches take two steps: finding top-N document
> ids, and filling documents of found ids.
> In this case, FeatureTransformer works in the second step and tries to
> extract features with LTRScoringQuery built in QueryComponent#prepare.
> However, because the second step doesn't call QueryComponent#process, the
> original query of LTRScoringQuery remains null and this causes
> NullPointerException while evaluating OriginalScoreFeature.
> We can get the original query from ResultContext which is an argument of
> DocTransformer#setContext, thus this problem can solve by using it if
> LTRScoringQuery doesn't have correct original query.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
