[ 
https://issues.apache.org/jira/browse/SOLR-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uwe Schindler updated SOLR-8689:
--------------------------------
    Attachment: SOLR-8689.patch

Hi,
this variant works, although it looks crazy: The {{\"}} escaping is ignored by 
the shell of windows, so it is passed as-is to Java (because "\" is not a good 
escape char on windows, so this approach won't work on Linux, but there are not 
colons in filenames!)

This patch does not do the same stuff like Linux, because we do not have easy 
regular expressions available in Windows. The GC_LOG_OPTS used as it was before 
the change on Java <= 8, but for Java 9 it is ignored. I have no better idea 
how to do this. IMHO, this is better than not working at all! I added 
documentation for this.

Does anybody have a better idea or knows how to do the same magic regex 
replcaments like in the linux shell script? Is the current approach acceptable, 
[~hossman]?

> bin/solr.cmd does not start with recent Verona builds of Java 9 because of 
> version parsing issue
> ------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8689
>                 URL: https://issues.apache.org/jira/browse/SOLR-8689
>             Project: Solr
>          Issue Type: Bug
>          Components: scripts and tools
>    Affects Versions: 5.5, 6.0
>         Environment: Windows 7
>            Reporter: Uwe Schindler
>            Priority: Blocker
>              Labels: Java9
>             Fix For: 7.0, master (8.0), 7.1
>
>         Attachments: SOLR-8689.patch, SOLR-8689.patch, SOLR-8689.patch
>
>
> At least on Windows, Solr 5.5 does not start with the shell script using a 
> Verona-Java-9 JDK:
> {noformat}
> *****************************************************
> JAVA_HOME = C:\Program Files\Java\jdk-9
> java version "9-ea"
> Java(TM) SE Runtime Environment (build 
> 9-ea+105-2016-02-11-003336.javare.4433.nc)
> Java HotSpot(TM) 64-Bit Server VM (build 
> 9-ea+105-2016-02-11-003336.javare.4433.nc, mixed mode)
> *****************************************************
> C:\Users\Uwe Schindler\Desktop\solr-5.5.0\bin>solr start
> ERROR: Java 1.7 or later is required to run Solr. Current Java version is: 
> 9-ea
> {noformat}
> I don't know if this is better with Linux, but I assume the version parsing 
> is broken (e.g., String#startsWith, interpret as floating point number,...)
> We should fix this before Java 9 gets released! The version numbering scheme 
> changed completely: http://openjdk.java.net/jeps/223



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to