[
https://issues.apache.org/jira/browse/SOLR-11276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136664#comment-16136664
]
Cao Manh Dat edited comment on SOLR-11276 at 8/22/17 11:32 AM:
---------------------------------------------------------------
Initial patch, the idea here is to remove
SolrZkClient.updateKeeper(SolrZooKeeper keeper) and let SolrZkClient to manage
when to close its keeper.
I also removed DefaultConnectionStrategy, because I think ZkUpdate is complex (
sometime it's hard to know where an Exception will be catched ).
ZkClientConnectionStrategy is enough for create new instance of SolrZooKeeper.
[[email protected]] [~andyetitmoves] [~shalinmangar] what do you think?
was (Author: caomanhdat):
Initial patch, the idea here is to remove
SolrZkClient.updateKeeper(SolrZooKeeper keeper) and let SolrZkClient to manage
when to close its keeper.
I also removed DefaultConnectionStrategy, because I think ZkUpdate is complex (
sometime it's hard to know where an Exception will be catched ).
ZkClientConnectionStrategy is enough for create new instance of SolrZooKeeper.
[[email protected]] [~andyetitmoves] [~shalinmangar] what do you think?
> Refactoring SolrZkClient + ConnectionManager + ConnectionStrategy
> ------------------------------------------------------------------
>
> Key: SOLR-11276
> URL: https://issues.apache.org/jira/browse/SOLR-11276
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Cao Manh Dat
> Attachments: SOLR-11276.patch
>
>
> I found OnReconnect mechanism of current SolrZkClient is very hard to follow.
> I think we should do some refactoring to make it cleaner.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
