[ 
https://issues.apache.org/jira/browse/LUCENE-7942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145252#comment-16145252
 ] 

Mano Kovacs commented on LUCENE-7942:
-------------------------------------

[[email protected]], there is a validation issue in the patch at 
GeoStandardPath.java#811:
{noformat}
-validate-source-patterns:
[source-patterns] tabs instead spaces: 
lucene/spatial3d/src/java/org/apache/lucene/spatial3d/geom/GeoStandardPath.java

BUILD FAILED
{noformat}

Could you please replace it? (I don't have write access)

> For Geo3d paths, aggregating distance values using "+" is not adequate for 
> squared distances
> --------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-7942
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7942
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial3d
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>             Fix For: 6.7, master (8.0), 7.1
>
>
> The GeoStandardPath object aggregates distances segment by segment using 
> simple addition.  For some kinds of Distance computations, though, addition 
> is not an adequate way to do this.  The xxxSquaredDistance computations, for 
> example, do not produce true squared distances but rather a distance metric 
> that is a combination of both squared and linear.
> I propose adding support in Distance for aggregation, which would allow 
> distance calculators to compute an accurate distance (at some computational 
> cost) instead.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to