[
https://issues.apache.org/jira/browse/LUCENE-7947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149008#comment-16149008
]
David Smiley commented on LUCENE-7947:
--------------------------------------
Usually a CHANGES.txt entry is added in the same commit as the code change. It
helps everyone become aware of what's happening, and also giving some credit to
contributors, as it's the best place where this is recorded (more accurate than
JIRA). You can add it later but I recommend against that; it can too easily be
forgotten.
> Add interface for point shapes
> ------------------------------
>
> Key: LUCENE-7947
> URL: https://issues.apache.org/jira/browse/LUCENE-7947
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial3d
> Reporter: Ignacio Vera
> Assignee: Karl Wright
> Priority: Minor
> Fix For: 6.7, master (8.0), 7.1
>
> Attachments: LUCENE-7947.patch, LUCENE-7947.patch
>
>
> Hi [~daddywri],
> Just one more thing .
> One of the shapes I normally use is a point shape. There is not such an
> interface so what I do currently is to build degenerated circles (circles
> with radius equal to 0) when I need such a shape. Still looks weird to have
> GeoCircles when you are dealing with points.
> My proposal is the following:
> 1) Add interface for point shapes which extends GeoCircle and GeoBBox. Not
> sure which name is appropiate but my take would be to call it GeoLatLonPoint.
> 2) Make GeoDegeneratedPoint implement this interface.
> 3) Add a factory to build GeoLatLonPoint .
> I am adding athe patch shortly.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
