[ 
https://issues.apache.org/jira/browse/SOLR-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149677#comment-16149677
 ] 

Hoss Man commented on SOLR-11305:
---------------------------------

[~ctargett]: the changes you just committed look fine to me, although 
personally i would suggest eliminating all of the "This class functions 
similarly to ..." sentences -- they made sense back when the Trie classes had a 
detailed description of how they work, but now it's just unnecessary noise. 
("oh, ok .. so this type doesn't require a precisionStep which is a thing that 
isn't explained anywhere else??? .. so then why are you bringing it up???")

Maybe they should all just have the structure...

{panel}
Foo field (xx-bit signed foo). This class encodes foo values using a 
"Dimensional Points" based data structure that allows for very efficient 
searches for specific values, or ranges of values. ...
{panel}

WDYT?

(All the of the changes in your commits look reasonable ... i'll try to take a 
look at the other pages/sections you mentioned soon.  Note that [this jira 
query|https://issues.apache.org/jira/issues/?jql=project%3DSOLR%20AND%20labels%3Dnumeric-tries-to-points%20AND%20resolution%3DUnresolved]
 _should_ identify all known caveats to using point fields -- or at least the 
ones i know of, unless someone else added new issues since i created that label 
and didn't tag them)

> Ref Guide: Update for *PointFields & deprecated Trie*Fields
> -----------------------------------------------------------
>
>                 Key: SOLR-11305
>                 URL: https://issues.apache.org/jira/browse/SOLR-11305
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: documentation
>            Reporter: Cassandra Targett
>            Assignee: Cassandra Targett
>            Priority: Minor
>
> The Ref Guide doesn't have much about Point fields, so needs to be updated 
> since they are now default numeric types.
> A few things to do:
> # Note that all Trie*Fields are deprecated.
> # Update the field type descriptions (in 
> {{field-types-included-with-solr.adoc}} so they don't refer to TrieFields to 
> describe how they function (like, "This works just like a Trie* field..."), 
> since that will be less & less relevant to users as time goes on.
> # Review all the mentions of Trie fields and replace them with new 
> configurations or descriptions that use PointFields instead.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to