[
https://issues.apache.org/jira/browse/SOLR-11309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150766#comment-16150766
]
Cassandra Targett commented on SOLR-11309:
------------------------------------------
Looks good, Varun, thanks.
A few notes:
* The current {{read-and-write-side-fault-tolerance.adoc}} page was left empty
instead of deleted - that will for sure fail the build, which it did for me
after applying your patch.
* You updated {{how-solrcloud-works.adoc}} to remove the old
{{read-and-write-side-fault-tolerance.adoc}} in the list of files under the
{{:page-children:}} frontmatter, but haven't yet added any of the new pages as
children of {{solrcloud.adoc}}. That leaves nav missing these pages since they
have no place in the hierarchy (even though I see they are linked from
{{solrcloud.adoc}}, you need to put them in the {{:page-children:}} frontmatter
since that's what populates the left nav).
* I feel like we're mixing information about how SolrCloud works with a section
called "How SolrCloud Works" and now a new section that's now titled
"SolrCloud Resilience" - my thought would be to make your two new pages as
direct children of {{how-solrcloud-works.adoc}}. But, I know part of the goal
is to surface this information more directly, and the whole thing needs a lot
of re-org, so I'm willing to go ahead with this structure until I can get a
chance to re-org it later (hopefully sooner than later, but later than now).
If you fix the first 2 issues in this list, I think you'd be OK to go ahead and
commit it.
> Split up the "Read and Write Side Fault Tolerance" ref guide page
> -----------------------------------------------------------------
>
> Key: SOLR-11309
> URL: https://issues.apache.org/jira/browse/SOLR-11309
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Varun Thacker
> Priority: Minor
> Attachments: SOLR-11309.patch
>
>
> This ref guide page has tons of information. We could split this out into two
> pages - one for the read and one for writes.
> Also we could split it out from the "How SolrCloud works" top level nav to
> "SolrCloud resiliency" nav which could in the future host a dedicated page
> on recoveries as well
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
