[
https://issues.apache.org/jira/browse/LUCENE-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151244#comment-16151244
]
Hoss Man commented on LUCENE-7949:
----------------------------------
alternatively: maybe {{check-working-copy}} should directly depend on
{{jar-checksums}} such that anyone running precommit will get this error and
see the diff locally and git-add the new file.
And/or: {{check-working-copy}} could be made smart enough treat the jar sha1
files as special, and give a more informative error about why it's failing.
> precommit should fail the build if any jar sha1 files contain any whitespace
> or newlines
> ----------------------------------------------------------------------------------------
>
> Key: LUCENE-7949
> URL: https://issues.apache.org/jira/browse/LUCENE-7949
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Hoss Man
> Labels: build
>
> as part of SOLR-11209, miller updated the sha1 files for the jar's he was
> upgrading, and somehow a trailing newline got added to one of them, which
> caused jenkins to freak out about modified source files as part of the build
> (IIUC because jenkins was rebuilding the sha files and noticing they were
> different -- just because of the trailing newline.
> If precommit validated/enforced the expected structure of the sha1 files we
> could prevent these types of confusing build failures down the road.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
