[
https://issues.apache.org/jira/browse/SOLR-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151646#comment-16151646
]
Shalin Shekhar Mangar commented on SOLR-11293:
----------------------------------------------
Thanks Dat. I reviewed the patch and it looks good to me. A few comments:
# You removed a piece of debug logging in PrepRecoveryOp. Can you restore it
please?
# {{switchTransactionLog}} isn't a very good name. The tlog is switched on
commit always. Perhaps it can be more explicitly called
{{copyUpdatesFromOldTlog}}.
# I see that DUH2 supports a commit with IGNORE_INDEXWRITER flag. It is okay as
a temporary fix but I don't like the complexity. Now, certain code paths copy
over old updates separately after a commit and one code path does the same
thing as part of the commit. I'd like to refactor this at some point later.
{quote}
Secondly, for inconsistent event happen ( no data get lost in this case ), the
master's must be emptied and the replica's index is not empty. Furthermore the
inconsistent state will gone when master do the next commit.
{quote}
You are quite right but I should point out that RTG becomes inconsistent during
this time on 7.0 without these fixes although the data might be recovered in
future. But yeah, I agree that we can let Solr 7.0 continue without these fixes.
Can you please add a more deterministic test for the scenario that you fixed?
If we don't need this fix in 7.0 then we have ample time.
> HttpPartitionTest fails often
> -----------------------------
>
> Key: SOLR-11293
> URL: https://issues.apache.org/jira/browse/SOLR-11293
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Noble Paul
> Assignee: Noble Paul
> Fix For: 7.1
>
> Attachments: SOLR-11293.patch, SOLR-11293.patch, SOLR-11293.patch
>
>
> https://jenkins.thetaphi.de/job/Lucene-Solr-master-MacOSX/4140/testReport/org.apache.solr.cloud/HttpPartitionTest/test/
> {code}
> Error Message
> Doc with id=1 not found in http://127.0.0.1:60897/b/xj/collMinRf_1x3 due to:
> Path not found: /id; rsp={doc=null}
> Stacktrace
> java.lang.AssertionError: Doc with id=1 not found in
> http://127.0.0.1:60897/b/xj/collMinRf_1x3 due to: Path not found: /id;
> rsp={doc=null}
> at
> __randomizedtesting.SeedInfo.seed([ACF841744A332569:24AC7EAEE4CF4891]:0)
> at org.junit.Assert.fail(Assert.java:93)
> at org.junit.Assert.assertTrue(Assert.java:43)
> at
> org.apache.solr.cloud.HttpPartitionTest.assertDocExists(HttpPartitionTest.java:603)
> at
> org.apache.solr.cloud.HttpPartitionTest.assertDocsExistInAllReplicas(HttpPartitionTest.java:558)
> at
> org.apache.solr.cloud.HttpPartitionTest.testMinRf(HttpPartitionTest.java:249)
> at
> org.apache.solr.cloud.HttpPartitionTest.test(HttpPartitionTest.java:127)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
