[
https://issues.apache.org/jira/browse/SOLR-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-11318:
-----------------------------------
Attachment: SOLR-11318.patch
Attached patch contains some tests or {{AssertTool}}. They were all pretty
easy to write.
In the course of my testing, I found a bug in AssertTool:
{code}
[~/c/l/solr] $ bin/solr assert --exitcode --not-started http://www.google.com
[~/c/l/solr] $ echo $?
1
{code}
The exit code of AssertTool is intended to be the number of assertions failed
(or 100) on error. The invocation above _should_ exit with an exit code of 0.
Unless anyone objects, I'll bundle a fix for this in with this patch.
> Add tests for AssertTool
> ------------------------
>
> Key: SOLR-11318
> URL: https://issues.apache.org/jira/browse/SOLR-11318
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
> Affects Versions: master (8.0)
> Reporter: Jason Gerlowski
> Priority: Minor
> Attachments: SOLR-11318.patch
>
>
> {{bin/solr}}'s {{AssertTool}} is unique in that almost all of its logic lives
> in Java-land, which makes it pretty straightforward to test.
> Any test-coverage we can add to the {{bin/solr}} logic is a good thing, as
> this is one of the first points of interactions for users.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
