[ 
https://issues.apache.org/jira/browse/SOLR-11242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151952#comment-16151952
 ] 

ASF subversion and git services commented on SOLR-11242:
--------------------------------------------------------

Commit 0f87ca5566083f9fd451938e16d2ef70b744bcfc in lucene-solr's branch 
refs/heads/branch_7x from [~dsmiley]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0f87ca5 ]

SOLR-11242: QueryParser: re-use the LookaheadSuccess exception.

(cherry picked from commit 3901a13)


> QueryParser should avoid creating an LookaheadSuccess(Error) object with 
> every instance
> ---------------------------------------------------------------------------------------
>
>                 Key: SOLR-11242
>                 URL: https://issues.apache.org/jira/browse/SOLR-11242
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 7.0, 6.6.1, master (8.0)
>            Reporter: Michael Braun
>            Assignee: David Smiley
>         Attachments: SOLR-11242.patch, SOLR-11242.png, 
> TestQueryPerfSpeedup.java
>
>
> Sampling of an application which includes a very heavy query load testing 
> against an EmbeddedSolrServer reveals a huge amount of the time spent on 
> initialization of the QueryParser itself, specifically an internal class 
> called LookaheadSuccess which extends from Error. With every instance of 
> QueryParser created, it spends time populating the stacktrace for this 
> object, which is created as a final instance variable (the variable called 
> jj_ls). 
> Ideally an exception shouldn't be used as a signaling mechanism, or at the 
> very least, not an exception created on every single object instantiation. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to