[
https://issues.apache.org/jira/browse/LUCENE-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153440#comment-16153440
]
Robert Muir commented on LUCENE-7956:
-------------------------------------
Looks good.
nit/style: the test was difficult to read, it seems like its "trying too hard"
to use the lambda feature? Or is it trying to do everything on one line (i
guess at this point stacktraces are already hopeless due to lambdas/streams but
still...)
Instead of:
{code}
String text = IntStream.range(0, 1000000).mapToObj(i ->
"a").collect(Collectors.joining());
{code}
Could we just do:
{code}
char text[1000000];
Arrays.fill(text, 'a');
...
{code}
> ICUNormalizer2CharFilter may fail with a StackOverFlow error
> ------------------------------------------------------------
>
> Key: LUCENE-7956
> URL: https://issues.apache.org/jira/browse/LUCENE-7956
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-7956.patch
>
>
> ICUNormalizer2CharFilter recursively fills up a buffer of 128 chars until the
> last char is neither a surrogate nor inert. On large inputs of non inert
> characters, this can cause a stack overflow error.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
