[ 
https://issues.apache.org/jira/browse/LUCENE-7392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153631#comment-16153631
 ] 

Adrien Grand commented on LUCENE-7392:
--------------------------------------

I think these limitations are ok. The patch looks good to me overall, some nit 
picks:
 - maybe we should make this class final?
 - there seems to be an indentation issue in the newRangeQuery helper method
 - the test has some lines that are commented out, should we just remove them?

bq. modifying BKDWriter (and supporting IndexableField classes) so Points based 
fields can use custom encodings that are not necessarily byte aligned

What kind of encodings are you thinking about?

> Add point based GeoBoundingBoxField as a new RangeField type
> ------------------------------------------------------------
>
>                 Key: LUCENE-7392
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7392
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Nicholas Knize
>         Attachments: LUCENE-7392.patch, LUCENE-7392.patch, LUCENE-7392.patch
>
>
> This issue will add a new point based {{GeoBoundingBoxField}} type for 
> indexing and querying 2D or 3D Geo bounding boxes. The intent is to construct 
> this as a RangeField type and limit the first two dimensions to the lat/lon 
> geospatial bounds (at 4 bytes each like {{LatLonPoint}}, while allowing an 
> optional 8 byte ({{double}}) third dimension to serve as an altitude 
> component for indexing 3D geospatial bounding boxes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to