[
https://issues.apache.org/jira/browse/LUCENE-7891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153714#comment-16153714
]
ASF subversion and git services commented on LUCENE-7891:
---------------------------------------------------------
Commit 7fabb47dc357d559ff391a1f6b60a1298d1e095c in lucene-solr's branch
refs/heads/branch_7x from Mike McCandless
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7fabb47 ]
LUCENE-7891: use a non-buggy LRU cache in Lucene's taxonomy facets, by default
> Default LRUType of LruTaxonomyWriterCache should be guaranteed to be correct
> ----------------------------------------------------------------------------
>
> Key: LUCENE-7891
> URL: https://issues.apache.org/jira/browse/LUCENE-7891
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 6.4, 6.5, 6.4.1, 6.4.2, 6.6, 6.5.1
> Reporter: Jan-Willem van den Broek
> Attachments: LUCENE-7891.patch
>
>
> LruTaxonomyWriterCache uses LRUType.LRU_HASHED by default. This has a very
> small but non-zero chance of producing incorrect results due to collisions in
> the longHashCode of FacetLabel. If such a collision occurs, then an affected
> document will get an incorrect facet.
> This has happened to us in production. While it is a rare occurrence, the
> consequences could be significant, and it was not immediately obvious what
> caused the problem. Therefore I think it is better if the default is changed
> to LRUType.LRU_STRING, which is guaranteed to be correct.
> I will add a patch containing this change as well as a test for the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
