[ 
https://issues.apache.org/jira/browse/SOLR-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047047#comment-13047047
 ] 

Dawid Weiss commented on SOLR-1804:
-----------------------------------

I am not considering changes to my code to be a personal attack, so no worries. 
And, since I'm a former assembly guy, straightforward code flow is what I 
understand and relate to -- I use Guava from time to time to catch up with the 
young and hippie buzzwords (closures, abstraction, you know the like :).

And seriously, our 99% of Guava use is for instantiating lists and maps without 
providing generics (something that the new Java release will be able to infer 
from the code anyway -- at least if I'm reading commit logs to the javac 
compiler right). The remaining 1% is for cascading list filters and sorting 
orders (which, after you get used to them a little bit, work out and read 
pretty nicely).

I'm not by all means saying we should switch to Guava; I used it because I saw 
it was in global lib/ directory (and this happened after the patch to Carrot2 I 
believe).

> Upgrade Carrot2 to 3.2.0
> ------------------------
>
>                 Key: SOLR-1804
>                 URL: https://issues.apache.org/jira/browse/SOLR-1804
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - Clustering
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>             Fix For: 3.1, 4.0
>
>         Attachments: SOLR-1804-carrot2-3.4.0-dev-trunk.patch, 
> SOLR-1804-carrot2-3.4.0-dev.patch, SOLR-1804-carrot2-3.4.0-libs.zip, 
> SOLR-1804.patch, carrot2-core-3.4.0-jdk1.5.jar
>
>
> http://project.carrot2.org/release-3.2.0-notes.html
> Carrot2 is now LGPL free, which means we should be able to bundle the binary!

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to