Sure, Uwe. I already have an RC ready, but I'll create another one once you commit this patch.
-Anshum > On Sep 8, 2017, at 4:59 AM, Uwe Schindler <[email protected]> wrote: > > Hi, > > I’d like to fix this: https://issues.apache.org/jira/browse/LUCENE-7963 > <https://issues.apache.org/jira/browse/LUCENE-7963> > I’s a performance regression caused by a useless line of code. It was > obviously added for debugging. It is dead code, so no risk at all. > > Uwe > > ----- > Uwe Schindler > Achterdiek 19, D-28357 Bremen > http://www.thetaphi.de <http://www.thetaphi.de/> > eMail: [email protected] <mailto:[email protected]> > > From: Adrien Grand [mailto:[email protected]] > Sent: Tuesday, September 5, 2017 9:20 PM > To: [email protected] > Subject: Re: [VOTE] Release Apache Lucene/Solr 7.0.0 RC2 > > I pushed it to the 7.0 branch. > > Le mar. 5 sept. 2017 à 14:53, Adrien Grand <[email protected] > <mailto:[email protected]>> a écrit : >> Since we are respinning, I'd like to push >> https://issues.apache.org/jira/browse/LUCENE-7956 >> <https://issues.apache.org/jira/browse/LUCENE-7956> to the 7.0 branch if >> there are no objections. >> >> Le lun. 4 sept. 2017 à 19:46, Anshum Gupta <[email protected] >> <mailto:[email protected]>> a écrit : >>> Thank you Alexandre for reporting this. >>> >>> It feels sensible to cancel out this RC, and fix the issues before >>> respinning. >>> >>> Anshum >>> >>> On Sat, Sep 2, 2017 at 9:32 AM Yonik Seeley <[email protected] >>> <mailto:[email protected]>> wrote: >>>> Thank you for going the extra mile checking this stuff out Alex! >>>> Some other responses inline... >>>> >>>> On Sat, Sep 2, 2017 at 11:28 AM, Alexandre Rafalovitch >>>> <[email protected] <mailto:[email protected]>> wrote: >>>> > -1 >>>> > >>>> > DIH example fails to load for 3 out of 5 examples: >>>> > >>>> > db: >>>> > org.apache.solr.common.SolrException:org.apache.solr.common.SolrException: >>>> > Could not load conf for core db: Can't load schema >>>> > /Users/arafalov/Downloads/solr-7.0.0/example/example-DIH/solr/db/conf/managed-schema: >>>> > Unknown fieldType 'tdouble' specified on field *_coordinate >>>> > mail: >>>> > org.apache.solr.common.SolrException:org.apache.solr.common.SolrException: >>>> > Could not load conf for core mail: Can't load schema >>>> > /Users/arafalov/Downloads/solr-7.0.0/example/example-DIH/solr/mail/conf/managed-schema: >>>> > Unknown fieldType 'tdouble' specified on field *_coordinate >>>> > solr: >>>> > org.apache.solr.common.SolrException:org.apache.solr.common.SolrException: >>>> > Could not load conf for core solr: Can't load schema >>>> > /Users/arafalov/Downloads/solr-7.0.0/example/example-DIH/solr/solr/conf/managed-schema: >>>> > Unknown fieldType 'tdouble' specified on field *_coordinate >>>> > >>>> > >>>> > Additional comments that probably cross several JIRAs: >>>> > *) The schemaless mode duplicates auto-guessed text fields to string >>>> > fields. Those string fields are docValues=true, indexed=false, >>>> > stored=false. But docValues do return their string representation so >>>> > the query now returns the same content in both guessed text field and >>>> > copied string field. I am not sure if that was the intention. >>>> >>>> useDocValuesAsStored="false" is needed on those fields perhaps? >>>> >>>> >>>> > *) In README.txt we tell how to start a server in 3 different ways, >>>> > but not at all how to stop one. Should we? >>>> >>>> Definitely! >>>> >>>> > *) http://lucene.apache.org/solr/quickstart.html >>>> > <http://lucene.apache.org/solr/quickstart.html> is now out of date in >>>> > couple of ways apart from the version >>>> > **) for the indexing of "docs/" as there is only 1 indexable file in >>>> > there are Javadocs were removed >>>> > **) The search for "foundation" against the book title no longer works >>>> > because the new schemaless mode no longer populates _text_ which we >>>> > are still searching. Actually, I am not sure the easiest way to get to >>>> > that result now >>>> > **) It also no longer works because we are not indexing Javadocs >>>> > **) curl >>>> > "http://localhost:8983/solr/gettingstarted/select?wt=json&indent=true&q=\ >>>> > >>>> > <http://localhost:8983/solr/gettingstarted/select?wt=json&indent=true&q=%5C>"CAS+latency\"" >>>> > also does not because we don't copy to _text_ but - on the mac - I am >>>> > having troubles with quoted strings too. Even this does not work: curl >>>> > "http://localhost:8983/solr/gettingstarted/select?defType=edismax&q=\ >>>> > <http://localhost:8983/solr/gettingstarted/select?defType=edismax&q=%5C>"CAS >>>> > latency\"&qf=features" >>>> > **) same with other searches, all because of _text_ I think >>>> >>>> >>>> Hmmm, that worked fine for me on the mac. >>>> As far as the _text_ issue, In general we should make sure to specify >>>> what fields we're searching (that's a better template for new users to >>>> follow). >>>> >>>> > *) techproducts example starts, but returns fileds like >>>> > "price_c____l_ns":0 , which I am not sure what is supposed to >>>> > demonstrate/represent. >>>> >>>> Ugh.. that is a pseudo-field being returned for the currency field >>>> type (not sure when that copyfield was added). >>>> Presumably the pseudo-field is being returned because it has docValues >>>> (which we can treat as column-stored fields now). >>>> Any copyField targets, as well as pseudo-fields, should have >>>> useDocValuesAsStored="false" set. >>>> >>>> >>>> -Yonik >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [email protected] >>>> <mailto:[email protected]> >>>> For additional commands, e-mail: [email protected] >>>> <mailto:[email protected]>
