[
https://issues.apache.org/jira/browse/SOLR-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158814#comment-16158814
]
Christine Poerschke commented on SOLR-10990:
--------------------------------------------
bq. Could we move in a separate method also the grouping business ...
Sure, further refactoring can be done. Specifically re: the grouping business
here, I've opted to not include it in the current patch because it would
complicate the reviewability of the patch by a fair amount for only a modest
increase in code readability.
PS: master commit done as per above, branch_7x cherry-pick to follow probably
on Monday.
> QueryComponent.process breakup (for readability)
> ------------------------------------------------
>
> Key: SOLR-10990
> URL: https://issues.apache.org/jira/browse/SOLR-10990
> Project: Solr
> Issue Type: Wish
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
>
> The method is currently very long i.e.
> https://github.com/apache/lucene-solr/blob/e2521b2a8baabdaf43b92192588f51e042d21e97/solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java#L300-L565
> and breaking it up along logical lines (ids, grouped distributed first
> phase, grouped distributed second phase, undistributed grouped, ungrouped)
> would make it more readable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
