[ 
https://issues.apache.org/jira/browse/LUCENE-7961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-7961:
--------------------------------
    Attachment: LUCENE-7961.patch

I fixed a bug in my comment and clarified that windows case.

> SimpleFSLockFactory should catch+box IOException (not 
> FileAlreadyExistsException | AccessDeniedException)
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-7961
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7961
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-7961.patch, LUCENE-7961.patch
>
>
> SimpleFSLockFactory will only convert {{FileAlreadyExistsException | 
> AccessDeniedException}} from Files.createFile() into 
> LockObtainFailedException. Neither of these are guaranteed from the API, only 
> {{IOException}}.
> I think SimpleFSLockFactory should box any IOException from 
> Files.createFile() into a LockObtainFailedException instead of just these two 
> optional ones. It is simpler and more consistent behavior, even if its just 
> theoretical problem for some FileSystem impl that doesn't throw these. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to