[ 
https://issues.apache.org/jira/browse/SOLR-10703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169287#comment-16169287
 ] 

ASF GitHub Bot commented on SOLR-10703:
---------------------------------------

Github user diegoceccarelli commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/202#discussion_r139309859
  
    --- Diff: solr/solrj/src/java/org/apache/solr/common/util/IOUtils.java ---
    @@ -31,7 +32,7 @@ public static void closeQuietly(Closeable closeable) {
             closeable.close();
           }
         } catch (Exception e) {
    -      LOG.error("Error while closing", e);
    +      SolrException.log(LOG, "Error while closing "+closeable.getClass());
    --- End diff --
    
    I had to modify the logging here in order to have `ignoreException` working 
in the tests. 


> DocTransformer implements Closeable
> -----------------------------------
>
>                 Key: SOLR-10703
>                 URL: https://issues.apache.org/jira/browse/SOLR-10703
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Diego Ceccarelli
>            Priority: Minor
>             Fix For: 7.0
>
>
> This patch -adds a {{prepare}} and a {{finish}} method to the interface of 
> {{DocTransformer}}- allowing a developer to perform actions before/after a 
> doc transformer is applied to a result set. My use case was to benchmark the 
> performance of a transformer, since transformer time is not part of 
> {{QTime}}. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to