[
https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169554#comment-16169554
]
Cao Manh Dat edited comment on SOLR-8344 at 9/18/17 4:00 AM:
-------------------------------------------------------------
Thanks for your review, that's great. But
bq. minor: It's debatable to me that RetrieveFieldsOptimizer is its own class.
It seems to me that a few static methods on DocsStreamer would be fine?
(package access for testing). No big deal though.
I think the purpose of the class is clear to me and this make the code look
better
bq. should we consider the presence of useDocValuesAsStored=false in one of the
fields that are both stored and docValues as a signal that we should not do
this optimization? I suppose so.
I maybe misunderstanding but {{useDocValuesAsStored=true}} only relate to
{{fl=*}} case and in that case, {{storedFields==null}} which is already skipped
in the patch.
was (Author: caomanhdat):
Thanks for your review, that's great.
bq. minor: It's debatable to me that RetrieveFieldsOptimizer is its own class.
It seems to me that a few static methods on DocsStreamer would be fine?
(package access for testing). No big deal though.
I think the purpose of the class is clear to me and this make the code look
better
bq. should we consider the presence of useDocValuesAsStored=false in one of the
fields that are both stored and docValues as a signal that we should not do
this optimization? I suppose so.
I maybe misunderstanding but {{useDocValuesAsStored=true}} only relate to
{{fl=*}} case and in that case, {{storedFields==null}} which is already skipped
in the patch.
> Decide default when requested fields are both column and row stored.
> --------------------------------------------------------------------
>
> Key: SOLR-8344
> URL: https://issues.apache.org/jira/browse/SOLR-8344
> Project: Solr
> Issue Type: New Feature
> Reporter: Ishan Chattopadhyaya
> Attachments: SOLR-8344.patch, SOLR-8344.patch
>
>
> This issue was discussed in the comments at SOLR-8220. Splitting it out to a
> separate issue so that we can have a focused discussion on whether/how to do
> this.
> If a given set of requested fields are all stored and have docValues (column
> stored), we can retrieve the values from either place. What should the
> default be?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
