[ 
https://issues.apache.org/jira/browse/SOLR-11291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169864#comment-16169864
 ] 

Christine Poerschke commented on SOLR-11291:
--------------------------------------------

[~ab] and I spoke about this offline. At present there's the 
{{SolrInfoBean.Group.shard}} enum choice associated with the 
{{SolrShardReporter}} class for which {{setCore(core)}} is called. Instead of 
having the {{SolrInfoBean.Group.shard}} enum choice (and a potential additional 
{{SolrInfoBean.Group.replica}} enum choice) we should be able to inspect the 
class and based on that call the {{setCore(core)}} method e.g. something along 
the lines of
{code}
if (SolrCoreReporter.class.isAssignableFrom(reporter.getClass())) {
  ((SolrCoreReporter)reporter).setCore(core);        
}
{code}
which then likely also should permit the removal altogether of the 
{{SolrInfoBean.Group.shard}} enum choice.

> Adding Solr Core Reporter
> -------------------------
>
>                 Key: SOLR-11291
>                 URL: https://issues.apache.org/jira/browse/SOLR-11291
>             Project: Solr
>          Issue Type: New Feature
>          Components: metrics
>            Reporter: Omar Abdelnabi
>            Priority: Minor
>         Attachments: SOLR-11291.patch
>
>
> Adds a new reporter, SolrCoreReporter, which allows metrics to be reported on 
> per-core basis.
> Also modifies the SolrMetricManager and SolrCoreMetricManager to take 
> advantage of this new reporter.
> Adds a test/example that uses the  SolrCoreReporter. Also adds randomization 
> to SolrCloudReportersTest.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to