[ 
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172931#comment-16172931
 ] 

Ignacio Vera edited comment on LUCENE-7951 at 9/20/17 10:40 AM:
----------------------------------------------------------------

I have merge the Geo3dAreaRptTest into Geo3dRptTest.

Unfortunately, the current implementation of Geo3dStandardCircle is an 
approximation and it shows up when trying to build shapes using circles with 
bearing points. Therefore the test in Geo3dShapeWGS84ModelRectRelationTest fail 
as some points are declared to be outside of the circle. 

The case of circles on spheroids is hard and you need to eventually use brute 
force (calculate the distance between the point/shape to center of the circle) 
if you want to be precise. I have an idea how to minimize the impact but it is 
on the limits of my maths capabilities. I opened a ticket (LUCENE-7970) to 
address the problem. 

Meanwhile the WGS84ModelRectRelationTest will fail when removing the doggy 
relate function. Note that it works for the sphere.




was (Author: ivera):
I have merge the Geo3dAreaRptTest into Geo3dRptTest. T

unfortunately, the current implementation of Geo3dStandardCircle is an 
approximation and it shows up when trying to build shapes using circles with 
bearing points. Therefore the test in Geo3dShapeWGS84ModelRectRelationTest fail 
as some points are declared to be outside of the circle. 

The case of circle on spheroids is hard and you need to eventually use brute 
force (calculate the distance between the point/shape to center of the circle) 
if you want to be precise. I have an idea how to minimize the impact but it is 
on the limits of my maths capabilities. I opened a ticket (LUCENE-7970) to 
address the problem. Meanwhile the WGS84 test will fail. Note that it works for 
the Sphere.



> New wrapper classes for Geo3d
> -----------------------------
>
>                 Key: LUCENE-7951
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7951
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial-extras
>            Reporter: Ignacio Vera
>            Assignee: David Smiley
>            Priority: Minor
>         Attachments: LUCENE_7951_build.patch, LUCENE_7951_build.patch, 
> LUCENE-7951.patch, LUCENE-7951.patch
>
>
> Hi,
> After the latest developments in the Geo3d library, in particular:
> [https://issues.apache.org/jira/browse/LUCENE-7906] : Spatial relationships 
> between GeoShapes
> [https://issues.apache.org/jira/browse/LUCENE-7936]: Serialization of 
> GeoShapes.
> I propose a new set of wrapper classes which can be for example linked to 
> Solr as they implement their own SpatialContextFactory. It provides the 
> capability of indexing shapes with 
>  spherical geometry.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to