[ 
https://issues.apache.org/jira/browse/LUCENE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174740#comment-16174740
 ] 

Ignacio Vera commented on LUCENE-7970:
--------------------------------------

(1) I was having problems with the maths so before going foward  in trying to 
solve/formalize it I wanted to see if the approach I was taken would be 
considered. First thing we need to do then, it is to formalize the way to 
compute the planes. I know there is something missing; there is a maximum 
cutoff angle which depends on the spheriod(ab,c) where the outerEllipse does 
not make sense and should be the whole planet. The same with the innerEllipse.  

(2) Ok, I think we can use only the outer plane as it is bigger than the shape. 
If null then bounds should be the whole world.Using the inner plane can give 
bounds smaller than the shape and we might want to avoid that.

(3) upps, my mistake ... shapes should not be public. 

I will try then to find the way to compute the planes that provides the desired 
inner and outer plane in a formal way. 

Thanks!



> Improve generation of circle plane 
> -----------------------------------
>
>                 Key: LUCENE-7970
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7970
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>         Attachments: LUCENE_7970.patch, LUCENE-7970.patch, 
> LUCENE-7970-proposed.patch
>
>
> Hi [~Karl wright],
> How circles are currently build do not behave very well when the planet model 
> is not an sphere. when you are close to the border in WGS84 you might get 
> false positves or false negatives when checking if a point is WITHIN. I think 
> the reason is how the points to generate the circle plane are generated which 
> assumes a sphere.
> My proposal is the following:
> Add a new method to PlanetModel:  
> public GeoPoint pointOnBearing(GeoPoint from, double dist, double bearing);
> Which uses and algorithm that takes into account that the planet might not be 
> spherical. For example Vincenty's formulae 
> (https://en.wikipedia.org/wiki/Vincenty%27s_formulae).
> Use this method to generate the points for the circle plane. My experiments 
> shows that this approach removes false negatives in WGS84 meanwhile it works 
> nicely in the Sphere.
> Does it make sense?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to