[ 
https://issues.apache.org/jira/browse/LUCENE-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179123#comment-16179123
 ] 

Michael McCandless commented on LUCENE-7975:
--------------------------------------------

Oh, woops, yes the {{xx}} is leftover -- I'll remove those methods.

bq. Do we really need the bytes ThreadLocal in UTF8TaxonomyWriterCache? It 
looks like it is always accessed under 'this' lock

Eeek, nice catch!  I meant to perf test w/ that code outside of the lock; I'll 
re-test and see if it's warranted.

> Replace facets taxonomy writer "cache" with BytesRefHash based implementation
> -----------------------------------------------------------------------------
>
>                 Key: LUCENE-7975
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7975
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: master (8.0), 7.1
>
>         Attachments: LUCENE-7975.patch
>
>
> When the facets module was first created we didn't have {{BytesRefHash}} and 
> so the default cache ({{Cl2oTaxonomyWriterCache}} was quite a bit more 
> complex than needed.
> I changed this to use a {{BytesRefHash}}, which stores labels as UTF8 
> (reduces memory for ascii-only usage), and is also faster (~12% overall 
> speedup on indexing time in my private tests).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to