[ 
https://issues.apache.org/jira/browse/SOLR-11391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181604#comment-16181604
 ] 

Yonik Seeley commented on SOLR-11391:
-------------------------------------

bq. The Join Q Parser now exposes a "useGraph" param. Should we expose it ?

No... it's a internal historical detail that is subject to change and doesn't 
communicate anything important.
If we do expose a "method" param for join, it should have something to do with 
the algorithm being used.
We could reuse some of the names that faceting uses:
 - "enum" for enumerating over indexed terms and checking each term for an 
intersection with the domain.  O(field_cardinality)
 - "dv" for doc values - for every document in the domain, we look up it's 
values O(n_documents_in_domain)
I'm not sure if those are the best names or not... but you get the idea.

> JoinQParser for non point fields should use the GraphTermsCollector 
> --------------------------------------------------------------------
>
>                 Key: SOLR-11391
>                 URL: https://issues.apache.org/jira/browse/SOLR-11391
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Varun Thacker
>         Attachments: SOLR-11391.patch, SOLR-11391.patch, SOLR-11391.patch
>
>
> The Join Query Parser uses the GraphPointsCollector for point fields. 
> For non point fields if we use the GraphTermsCollector instead of the current 
> algorithm I am seeing quite a bit of performance gains.
> I'm going to attach a quick patch which I cooked up , making sure TestJoin 
> and TestCloudJSONFacetJoinDomain passed. 
> More tests, benchmarking and code cleanup to follow



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to