[
https://issues.apache.org/jira/browse/LUCENE-7980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183109#comment-16183109
]
Robert Muir commented on LUCENE-7980:
-------------------------------------
I don't think we should do this, thats more confusing to a lucene user.
The method is {{setMaxMergesAndThreads(int maxMergeCount, int
maxThreadCount)}}, so you have to pass both maxMergeCount and maxThreadCount to
this method, because the java compiler enforces that. So as a java user, this
message would just confuse me.
Seems like maybe the problem is really missing validation on the solr side.
> Improve ERROR msg on setting maxThreadCount & maxMergeCount for
> ConcurrentMergeScheduler
> ----------------------------------------------------------------------------------------
>
> Key: LUCENE-7980
> URL: https://issues.apache.org/jira/browse/LUCENE-7980
> Project: Lucene - Core
> Issue Type: Improvement
> Affects Versions: 7.1
> Reporter: Amrit Sarkar
> Attachments: LUCENE-7980.patch
>
>
> SOLR-11257
> [~thelabdude],
> I tried tuning the maxThreadCount for my Concurrent scheduler using:
> {code}
> <mergeScheduler class="org.apache.lucene.index.ConcurrentMergeScheduler">
> <int name="maxThreadCount">4</int>
> </mergeScheduler>
> {code}
> and got:
> Validation errors:
> {{Error:
> java.lang.IllegalArgumentException:java.lang.IllegalArgumentException: both
> maxMergeCount and maxThreadCount must be AUTO_DETECT_MERGES_AND_THREADS}}
> Hmmm ... don't know what that means? As I user I need a better error message
> than that ^ Of course looking at the code, it seems I must also set:
> maxMergeCount but that error doesn't tell me that. So this bug is about
> fixing up the error to be more helpful to the user. Of course this is
> advanced functionality, so maybe expecting me to read the code to understand,
> in which case, just close this as invalid.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
