[ https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Gerlowski updated SOLR-7871: ---------------------------------- Attachment: SOLR-7871.patch This patch finished all the work that remained to be done on this (AFAIK). Added in this patch: - additional Windows (solr.cmd) bugfixes. - install_solr_service.sh now looks for and installs solr.conf files, as well as existing solr.in.sh files - Updates the config-manipulation code in {{bin/solr auth}} to be able to write the new configuration format. - pulls out a lot more default values into "solr-defaults.conf", including GC logging and tuning options. - updates asciidoc documentation to refer to the new config file format, and mention that the platform-dependent config files are still usable but deprecated. Tests and precommit all pass. AFAIK this is fully ready for review. Would appreciate any feedback anyone has. > Platform independent config file instead of solr.in.sh and solr.in.cmd > ---------------------------------------------------------------------- > > Key: SOLR-7871 > URL: https://issues.apache.org/jira/browse/SOLR-7871 > Project: Solr > Issue Type: Improvement > Components: scripts and tools > Affects Versions: 5.2.1 > Reporter: Jan Høydahl > Assignee: Jan Høydahl > Labels: bin/solr > Attachments: SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, > SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, > SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch > > > Spinoff from SOLR-7043 > The config files {{solr.in.sh}} and {{solr.in.cmd}} are currently executable > batch files, but all they do is to set environment variables for the start > scripts on the format {{key=value}} > Suggest to instead have one central platform independent config file e.g. > {{bin/solr.yml}} or {{bin/solrstart.properties}} which is parsed by > {{SolrCLI.java}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org