[
https://issues.apache.org/jira/browse/SOLR-11425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195039#comment-16195039
]
Shawn Heisey commented on SOLR-11425:
-------------------------------------
I can understand the instinct that led the design to exclude a value of zero,
and even though infinite timeouts can be problematic, I think the patch for
this issue is a good change -- it's not our job to enforce a finite timeout.
I do wonder if perhaps the javadoc should have a note about zero being an
infinite timeout, which could result in client operations that never return.
> SolrClientBuilder does not allow infinite timeout (value 0)
> -----------------------------------------------------------
>
> Key: SOLR-11425
> URL: https://issues.apache.org/jira/browse/SOLR-11425
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrJ
> Affects Versions: 7.0
> Reporter: Peter Szantai-Kis
> Assignee: Mark Miller
> Fix For: 7.1, master (8.0)
>
> Attachments: SOLR-11425.patch, SOLR-11425.patch
>
>
> [org.apache.solr.client.solrj.impl.SolrClientBuilder#withConnectionTimeout|https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/client/solrj/impl/SolrClientBuilder.java#L53]
> does not allow to set the value of 0 which means infinite timeout, but
> [RequestConfig|https://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/client/config/RequestConfig.html#getConnectTimeout()]
> where it will be used have the option to do so.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
