[ 
https://issues.apache.org/jira/browse/SOLR-11449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198501#comment-16198501
 ] 

ASF subversion and git services commented on SOLR-11449:
--------------------------------------------------------

Commit 338a421175e86ae6ba6a3da6719edd0061150af7 in lucene-solr's branch 
refs/heads/master from [~ab]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=338a421 ]

SOLR-11449: MoveReplicaCmd mistakenly called registerCollectionStateWatcher on 
failure.


> MoveReplicaCmd mistakenly calls registerCollectionStateWatcher instead of 
> unregisterCollectionStateWatcher
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-11449
>                 URL: https://issues.apache.org/jira/browse/SOLR-11449
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 7.0.1, 7.1, master (8.0)
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>         Attachments: SOLR-11449.patch
>
>
> Probably got in as a copy & paste error:
> {code}
> --- a/solr/core/src/java/org/apache/solr/cloud/MoveReplicaCmd.java
> +++ b/solr/core/src/java/org/apache/solr/cloud/MoveReplicaCmd.java
> @@ -206,7 +206,7 @@ public class MoveReplicaCmd implements Cmd{
>        log.warn(errorString);
>        results.add("failure", errorString);
>        if (watcher != null) { // unregister
> -        ocmh.zkStateReader.registerCollectionStateWatcher(coll.getName(), 
> watcher);
> +        ocmh.zkStateReader.removeCollectionStateWatcher(coll.getName(), 
> watcher);
>        }
>        return;
>      }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to