[ 
https://issues.apache.org/jira/browse/SOLR-11464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gus Heck updated SOLR-11464:
----------------------------
    Attachment: SOLR-11464.patch

Patch... I get test failures, but never the same failure twice in 3 runs.... 
the last 2 runs gave these 2. 

   [junit4] Tests with failures [seed: B463494894C3DC36]:
   [junit4]   - 
org.apache.solr.cloud.autoscaling.ComputePlanActionTest.testNodeLost

and 

   [junit4] Tests with failures [seed: A1D7C7A98F6442C9]:
   [junit4]   - org.apache.solr.cloud.LeaderElectionContextKeyTest.test

None look related, but the tests seem generally unstable (this was true before 
this patch too), but I did get a success earlier today, which was the first 
time in half a dozen runs of test clean from the top. I do have the number of 
concurrent threads cranked up to try to take advantage of my new Threadripper 
processor... I guess I'll have to reduce it and see if that helps with stability


> Unused code in DistributedUpdateProcessor
> -----------------------------------------
>
>                 Key: SOLR-11464
>                 URL: https://issues.apache.org/jira/browse/SOLR-11464
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrCloud
>    Affects Versions: master (8.0)
>            Reporter: Gus Heck
>            Priority: Minor
>         Attachments: SOLR-11464.patch, unused.png
>
>
> While reading code I ran across a couple of suspicious unused 
> values/variables. Thought I would raise this so that folks can consider if 
> something was lost here, or if perhaps we can eliminate an unnecessary call 
> to zookeeper and tidy things up a bit. Screenshot and patch to eliminate 
> shortly...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to