[
https://issues.apache.org/jira/browse/SOLR-11444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204755#comment-16204755
]
Erick Erickson commented on SOLR-11444:
---------------------------------------
IIRC, that test in SOLR-11218 _used_ to work in which case the behavior is now
different (and, I think, correct). Of course I may be mis-remembering...
Let's claim I'm remembering correctly for a second though: the test
{{testDeleteAliasWithExistingCollectionName}} used to work but was only showing
incorrect behavior. That lends weight to the discussions in SOLR-11488 and
SOLR-11489 I think. At least we should beef up the tests a _lot_ to have faith
that
1> the behavior is what we expect
2> future changes don't unexpectedly break things
I'd prefer a more systemic change of course.
To be clear, the discussions at SOLR-11488 and SOLR-11489 should _not_ hold up
this JIRA. In fact I'd be loathe to do either of them before this one is
committed.
And on a side note, WDYT about including the bits from SOLR-11488 that
dis-allows deleting a collection if _any_ alias points to it in this JIRA? The
nocommit test {{testDeleteOneOfTwoCollectionsAliased}} in SOLR-11218 exercises
that and IIRC we get an error if we query on an alias after deleting only one
of the collections pointed to by it.
> Improve Aliases.java and comma delimited collection list handling
> -----------------------------------------------------------------
>
> Key: SOLR-11444
> URL: https://issues.apache.org/jira/browse/SOLR-11444
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
> Reporter: David Smiley
> Assignee: David Smiley
> Attachments: SOLR_11444_Aliases.patch, SOLR_11444_Aliases.patch
>
>
> While starting to look at SOLR-11299 I noticed some brittleness in
> assumptions about Strings that refer to a collection. Sometimes they are in
> fact references to comma separated lists, which appears was added with the
> introduction of collection aliases (an alias can refer to a comma delimited
> list). So Java's type system kind of goes out the window when we do this.
> In one case this leads to a bug -- CloudSolrClient will throw an NPE if you
> try to write to such an alias. Sending an update via HTTP will allow it and
> send it to the first in the list.
> So this issue is about refactoring and some little improvements pertaining to
> Aliases.java plus certain key spots that deal with collection references. I
> don't think I want to go as far as changing the public SolrJ API except to
> adding documentation on what's possible.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
