[
https://issues.apache.org/jira/browse/SOLR-11292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208425#comment-16208425
]
Varun Thacker commented on SOLR-11292:
--------------------------------------
I think the logic *only* fails when we have a collection name and alias with
the same name
{code}
private LinkedHashSet<String> resolveAliasesAndValidateExistence(List<String>
inputCollections) {
LinkedHashSet<String> collectionNames = new LinkedHashSet<>(); //
consistent ordering
// validate collections
for (String collectionName : inputCollections) {
if (stateProvider.getState(collectionName) == null) {
// perhaps it's an alias
List<String> aliasedCollections =
stateProvider.getAlias(collectionName);
if (aliasedCollections.isEmpty()) {
throw new SolrException(ErrorCode.BAD_REQUEST, "Collection not found:
" + collectionName);
}
collectionNames.addAll(aliasedCollections);
} else {
collectionNames.add(collectionName);
}
}
return collectionNames;
}
{code}
We are first checking if the collection exists. If the collection doesn't exist
only then do we resolve it as an alias.
Maybe we should always resolve it as an alias first?
> Querying against an alias can lead to incorrect routing
> -------------------------------------------------------
>
> Key: SOLR-11292
> URL: https://issues.apache.org/jira/browse/SOLR-11292
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Varun Thacker
> Assignee: Varun Thacker
>
> collection1 has 2 shards and 1 replica
> collection2 has 8 shards and 1 replica
> I have 8 nodes so collection2 is spread across all 8 , while collection1 is
> hosted by two nodes
> If we create an alias called "collection1" and point it to "collection2".
> Querying against the alias "collection1" works as expected but what I noticed
> was the top level queries would only hit 2 out of the 8 JVMs when querying
> using SolrJ
> It turns out that SolrJ is using the state.json of collection1 ( the actual
> collection ) and routing queries to only those nodes.
> There are two negatives to this:
> - If those two nodes are down all queries fail.
> - Top level queries are only routed to those two nodes thus causing a skew
> in the top level requests
> The obvious solution would be to use the state.json file of the underlying
> collection that the alias is pointing to . But if we have the alias pointing
> to multiple collections then this might get tricky?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
