On Fri, Oct 20, 2017 at 5:29 PM, Hrishikesh Gadre <[email protected]> wrote: > Yes that seems to be case. But in this case, we are using Derby for unit > testing only. In production > deployments we would be using a standard RDBMS (e.g. mysql, postgres etc.). > So I am wondering > if we should provide a knob to suppress the randomization in such cases > (just to avoid such issues with third-party software). > e.g. we already have an annotation to suppress SSL > (@SolrTestCaseJ4.SuppressSSL). May be we could do something similar > for the Locale setting? > > To ensure that such setting is not abused inside lucene-solr repo, we can > add it to the list of forbidden APIs. > > If this is acceptable, I will go ahead and create a jira. >
I agree its a good idea if we can better allow the test class to not run under specific locales. This would have some use-cases such as temporarily disabling turkish/azeri locales when String.lowerCase() is used incorrectly and other common problems. I think a SuppressLocaleRandomization or similar is a good idea. Maybe it should instead just "wire" the class to a specified locale parameter (e.g. "en-US") to make it totally clear what will happen (tests still are repeatable for developers in different countries and so on). +1 to open issue. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
