[
https://issues.apache.org/jira/browse/LUCENE-7997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-7997:
--------------------------------
Attachment: LUCENE-7997_wip.patch
Updated patch with all remaining sims (axiomatic and language models) now
tested.
The axiomatic F3EXP and F3LOG fail due to their gamma function driving scores
negative, I added a warning to their javadocs about this. Also note that these
two models don't have default parameter-free ctors. The other 4 models (F1EXP,
F1LOG, F2EXP, F2LOG) are all fine, they don't have this gamma function.
At least now we have the lay of the land, it is as expected.
Still need to deal with many parameters which aren't yet tested. In many cases
these are also missing any range checks, we need to dig up/figure out the valid
domain, randomize them, look for issues etc. But the default values are tested.
> More sanity testing of similarities
> -----------------------------------
>
> Key: LUCENE-7997
> URL: https://issues.apache.org/jira/browse/LUCENE-7997
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-7997_wip.patch, LUCENE-7997_wip.patch,
> LUCENE-7997_wip.patch, LUCENE-7997_wip.patch, LUCENE-7997_wip.patch,
> LUCENE-7997_wip.patch, LUCENE-7997_wip.patch, LUCENE-7997_wip.patch,
> LUCENE-7997_wip.patch
>
>
> LUCENE-7993 is a potential optimization that we could only apply if the
> similarity is an increasing functions of {{freq}} (all other things like DF
> and length being equal). This sounds like a very reasonable requirement for a
> similarity, so we should test it in the base similarity test case and maybe
> move broken similarities to sandbox?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
