[ 
https://issues.apache.org/jira/browse/LUCENE-8018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221837#comment-16221837
 ] 

Robert Muir commented on LUCENE-8018:
-------------------------------------

I am concerned about the complexity here introduced by "millions of fields" 
abuse case.

I pushed back against this from the very beginning and it appears the nightmare 
i predicted has become the reality: I can't tell what any of this FieldInfos 
code is even doing here, much less this patch.

I definitely don't think we should be adding any optimization here. Instead we 
should be carefully undoing existing optimizations to try to manage the 
technical debt here.

> FieldInfos retains garbage if non-sparse
> ----------------------------------------
>
>                 Key: LUCENE-8018
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8018
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/store
>    Affects Versions: 6.5
>         Environment: Lucene 6.5.0, java 8
> openjdk version "1.8.0_45-internal"
> OpenJDK Runtime Environment (build 1.8.0_45-internal-b14)
> OpenJDK 64-Bit Server VM (build 25.45-b02, mixed mode)
>            Reporter: Julian Vassev
>              Labels: easyfix, performance
>             Fix For: master (8.0), 7.2
>
>         Attachments: LUCENE-8018.patch
>
>
> A heap dump revealed a lot of TreeMap.Entry instances (millions of them) for 
> a system with about ~1000 active searchers.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to